Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dweb:/ipns/libp2p.io false-negative error #923

Closed
lidel opened this issue Sep 15, 2020 · 1 comment
Closed

dweb:/ipns/libp2p.io false-negative error #923

lidel opened this issue Sep 15, 2020 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization
Milestone

Comments

@lidel
Copy link
Member

lidel commented Sep 15, 2020

Seems there is a regression opening dweb:/ipns/libp2p.io when using IPFS companion in Firefox does not work as expected.

We don't promote use of dweb: URI at the moment, but hould be an easy fix (probably regex needs updating).

Also, ipns://almonit.eth / ipns://almonit.eth.link fail in Firefox, could be related those got fixed in v2.17.1 :-)

@lidel lidel added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Sep 15, 2020
@lidel lidel added this to the v2.15 milestone Sep 15, 2020
@lidel lidel modified the milestones: v2.15, v2.16 Oct 19, 2020
@lidel lidel modified the milestones: v2.16, v2.17 Nov 18, 2020
@lidel lidel modified the milestones: v2.17, v2.18 Jan 11, 2021
@lidel
Copy link
Member Author

lidel commented May 14, 2021

We abandoned dweb scheme for now, as it is not compatible with web security model on the web.

We switched to native router in #999 so it is no longer in Companion's scope.
With go-ipfs 0.8.0, opening dweb:/ipns/libp2p.io produces:

uri query parameter scheme must be ipfs or ipns: %!s(<nil>)

This should be enough as a deprecation warning, pointing people to move to ipfs:// and ipns://

@lidel lidel closed this as completed May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

1 participant