Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing favicon #902

Closed
lidel opened this issue Jun 25, 2020 · 3 comments · Fixed by #906
Closed

Missing favicon #902

lidel opened this issue Jun 25, 2020 · 3 comments · Fixed by #906
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up

Comments

@lidel
Copy link
Member

lidel commented Jun 25, 2020

Various screens are lacking favicon:

  • Welcome screen
  • Preferences
  • Share files via IPFS (quick-upload)

We probably could reuse one from ipfs/dir-index-html#36 –
@jessicaschilling thoughts?
@lidel lidel added kind/bug A bug in existing code (including security flaws) help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up exp/beginner Can be confidently tackled by newcomers effort/hours Estimated to take one or several hours labels Jun 25, 2020
@jessicaschilling
Copy link
Contributor

@lidel I'm seeing favicons on all those pages. Confused.

image

@jessicaschilling
Copy link
Contributor

Update: Favicons display in Chrome, but not Firefox.

@lidel
Copy link
Member Author

lidel commented Jun 25, 2020

I guess when there is no explicit favicon defined in HTML loaded from browser extension Chrome fallbacks to extension's icon, and Firefox does not. So adding explicit definition should fix firefox.

@jessicaschilling jessicaschilling mentioned this issue Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add favicon to welcome, options, quick-import pages ipfs/ipfs-companion
2 participants
@lidel @jessicaschilling