Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

fix: ipns over pubsub tests #395

Merged
merged 3 commits into from
Dec 3, 2018
Merged

fix: ipns over pubsub tests #395

merged 3 commits into from
Dec 3, 2018

Conversation

vasco-santos
Copy link
Contributor

If we have an IPNS record value in cache, we will not hit the resolver and consequently, we are not going to subscribe the topic, as it is only subscribed when we are looking for it.

According to the above, I removed the publish prior to the resolve in the tests, which lead to some changes in the structure of the test, as resolve will return an error, as a consequence of not having any record.

@ghost ghost assigned vasco-santos Nov 20, 2018
@ghost ghost added the in progress label Nov 20, 2018
Copy link
Contributor

@hugomrdias hugomrdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

js/src/name-pubsub/cancel.js Outdated Show resolved Hide resolved
js/src/name-pubsub/cancel.js Outdated Show resolved Hide resolved
js/src/name-pubsub/cancel.js Outdated Show resolved Hide resolved
js/src/name-pubsub/cancel.js Outdated Show resolved Hide resolved
@alanshaw alanshaw merged commit e872b8a into master Dec 3, 2018
@alanshaw alanshaw deleted the fix/ipns-over-pubsub-tests branch December 3, 2018 19:03
@ghost ghost removed the in progress label Dec 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants