Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: package improvements #10

Open
4 tasks
SgtPooki opened this issue Aug 31, 2023 · 1 comment
Open
4 tasks

feat: package improvements #10

SgtPooki opened this issue Aug 31, 2023 · 1 comment
Labels
need/triage Needs initial labeling and prioritization

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Aug 31, 2023

See comment from @BigLep at #1 (comment)

  1. We send relayed addresses for Pin.origins
  2. We should only throw an error if we didn't have any public addresses in Pin.origins AND we couldn't connect to Pin.delegates.
  3. Can we produce API docs that make clear when/what errors are thrown?
  4. Make sure README points to the example being created in feat: create helia-remote-pinning example ipfs-examples/helia-examples#86

Tasks

@SgtPooki SgtPooki added the need/triage Needs initial labeling and prioritization label Aug 31, 2023
@SgtPooki
Copy link
Member Author

SgtPooki commented Sep 7, 2023

We should provide default filters and allow users to override them.

const multiaddrs = this.heliaInstance.libp2p.getMultiaddrs().filter(multiaddr => P2P.matches(multiaddr))

libp2p.getMultiaddrs() only returns addresses that the node is listening on so we only need to filter for public/private by default, and allow users to override that filter for extraneous situations.

if p2p-circuit is enabled, a libp2p node will likely double the number of listening multiaddrs, so we may need to optimize filtering more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

1 participant