Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Tests should not rely on go-libp2p-kad-dht #5

Closed
hsanjuan opened this issue Mar 16, 2021 · 2 comments
Closed

Tests should not rely on go-libp2p-kad-dht #5

hsanjuan opened this issue Mar 16, 2021 · 2 comments

Comments

@hsanjuan
Copy link
Contributor

This is a follow up issue to ipfs/kubo#7925.

@aschmahmann in the tests, we use libp2p nodes with dht. This tests ipns publishing more or less realistically. What should we using instead?

@Stebalien
Copy link
Member

Unfortunately, it's a bit more than that. We also specify the "dht record count". However, I think we can likely just drop that and replace it with a better option.

At this point, we should have simple "allow-stale" flag (or something like that):

  • When set, we take the first record found and return it.
  • When unset, we wait until the query completes.

@hacdias
Copy link
Member

hacdias commented Jun 12, 2023

This repository is no longer maintained and has been copied over to Boxo. In an effort to avoid noise and crippling in the Boxo repo from the weight of issues of the past, we are closing most issues and PRs in this repo. Please feel free to open a new issue in Boxo (and reference this issue) if resolving this issue is still critical for unblocking or improving your usecase.

You can learn more in the FAQs for the Boxo repo copying/consolidation effort.

@hacdias hacdias closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants