Skip to content
This repository has been archived by the owner on Aug 20, 2021. It is now read-only.

install option for non-linux users #8

Open
whyrusleeping opened this issue Aug 16, 2017 · 3 comments
Open

install option for non-linux users #8

whyrusleeping opened this issue Aug 16, 2017 · 3 comments

Comments

@whyrusleeping
Copy link
Member

We have a way to build plugins directly into the go-ipfs binary, this would allow users of windows and macOS to use this code natively, but would require they recompile. It also requires a little bit of changes in this package. Notably, we need to separate the 'package main' plugin code from the rest of the plugin scaffolding. And would end up with the main plugin file looking like:

package main

import (
     "ipldethpluginimportpath"
)

var Plugins = ipldeth.Plugins

See https://github.com/ipfs/go-ipfs/blob/master/plugin/loader/preload_list and other code in that directory.

cc @Kubuxu to help out.

@ghost
Copy link

ghost commented Aug 16, 2017

@whyrusleeping I did this executable to be able to build the plugin into the go-ipfs binary. It is mentioned in the plugin's README.

https://github.com/ipfs/go-ipld-eth/blob/master/plugin/hacks/osx.sh

@ghost ghost closed this as completed Aug 21, 2017
@Kubuxu
Copy link
Member

Kubuxu commented Aug 21, 2017

Adopting this option naively (moving the core of the plugin out of main package and providing separate main package) would allow much easier build of such plugin as pre-loaded plugin. It would be just changing a line in go-ipfs preload_list instead of having to rewrite files in this repo.

@ghost
Copy link

ghost commented Aug 21, 2017

I see what you mean @Kubuxu.

@ghost ghost reopened this Aug 21, 2017
@ghost ghost mentioned this issue Nov 7, 2017
@ghost ghost self-assigned this Nov 7, 2017
@ghost ghost removed their assignment Aug 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants