fix: fix duplicate block issue in bitswap #7202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Increase broadcast timeout. 2. Fix use of sessions when pinning. This also includes some bitswap changes to reduce some memory allocations and optimize some hot spots.
Stebalien
force-pushed
the
fix/duplicate-blocks
branch
from
e59bf1e
to
5d13ac3
Compare
Stebalien
commented
Apr 23, 2020
| @@ -75,6 +80,10 @@ func (s *syncDagService) Sync() error { | |||
| return s.syncFn() | |||
| } | |||
|
|
|||
| func (s *syncDagService) Session(ctx context.Context) format.NodeGetter { | |||
There was a problem hiding this comment.
This lets mdag.FetchGraph correctly setup a bitswap session. A better fix is in #7201 but that's not going to make it into the release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes some bitswap changes to reduce some memory allocations and optimize some hot spots.