fix #2203: omit the charset attribute when Content-Type is text/html #6743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Abdeldjalil Hebal <dreamski21@gmail.com>
|
Grrr... I PR'ed the wrong code. I have actually converted content from It was ugly and feels redundant. Should I recommit it or is there a better way to convert to |
Stebalien
requested changes
Nov 5, 2019
License: MIT Signed-off-by: Abdeldjalil Hebal <dreamski21@gmail.com>
|
Again, I'm horribly sorry for the annoyance. I shouldn't have opened this pull request in the first place as I have zero knowledge of Go. This won't happen again (not here, not on another project). You can either close this PR or just maybe fix, either way is fine. I'm just tired of it. *Tipped IPFS 20 BATs* |
|
This is not annoying at all. Fixing small bugs like this is a great way to learn a language and start contributing to a project. |
Stebalien
approved these changes
Dec 2, 2019
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
…-type-header fix #2203: omit the charset attribute when Content-Type is text/html This commit was moved from ipfs/kubo@c19bc36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2203