pin: add context and error return to most of the Pinner functions #6715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelMure
commented
Oct 17, 2019
|
CI failure doesn't seems related. |
|
@Stebalien could you have a look ? |
Stebalien
requested changes
Nov 15, 2019
MichaelMure
force-pushed
the
pinner-with-context
branch
from
2010fca
to
cd7c83a
Compare
|
Alright, PR comments addressed and rebased. I connected an extra context that was just waiting for it. The last thing would be to edit go.mod once ipfs/go-ipfs-provider#16 is merged. |
Stebalien
approved these changes
Nov 18, 2019
|
LGTM! I've merged and bubbled the provider dep change. I'll merge once CI passes. |
|
🚀 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Infura we have the need for a custom out-of-process (remote actually)
Pinner. Problem is, at the moment this interface assume that the list of pins is loaded in memory and access are instant and can't fail.This PR add a context for cancellation and a return error to most of the functions of
Pinner. Almost everything else is a consequence of those changes (see my comment later for the excessive locking).This PR use a forked
go-ipfs-providerto follow those changes, PR at ipfs/go-ipfs-provider#16