feat: add ipfs version info to prometheus metrics #6688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `ipfs_info` prometheus metric with version and commit info
```prometheus
ipfs_info{commit="9ea7c6a11-dirty",version="0.5.0-dev"} 1
```
This follows the same pattern as go and other systems, adding a gauge metric that is set to 1, with the version info addeds as labels.
This is a common pattern for prometheus. It lets operators merge version info into other prometheus metrics by multiplying it with the other stat, as described in https://www.robustperception.io/exposing-the-software-version-to-prometheus
For example, we already expose the go version info as
```prometheus
go_info{version="go1.12.9"} 1
```
License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
Stebalien
approved these changes
Sep 30, 2019
Kubuxu
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ipfs_infoprometheus metric with version and commit info to http://localhost:5001/debug/metrics/prometheus output...This follows the same pattern as go and other systems, adding a gauge metric that is set to 1, with the version info added as labels.
This is a common pattern for prometheus. It lets operators merge version info into other prometheus metrics by multiplying it with the other stat. As the value is always 1, it simply adds the labels to the aggregated info but does not change the other stats value... as described in https://www.robustperception.io/exposing-the-software-version-to-prometheus
For example, we already expose the go version info as
Part of #5604
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io