Load plugins on darwin/macOS #6439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
previously requested changes
Jun 12, 2019
| @@ -1,4 +1,5 @@ | |||
| // +build !noplugin | |||
| // +build linux,cgo darwin,cgo | |||
There was a problem hiding this comment.
Plugins shouldn't require cgo, right?
Stebalien
dismissed
their stale review
Oh, it does require CGO. That could explain a few things...
Stebalien
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously plugins were only loaded on linux. Darwin also supports plugins. The build constraint matches that of the standard library
pluginpackage (see).Note: The
pluginpackage requires cgo. So builds for darwin should be build on darwin to support plugins.