Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run JS interop in CircleCI #6409

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Run JS interop in CircleCI #6409

merged 1 commit into from
Jun 5, 2019

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Jun 5, 2019

@magik6k magik6k force-pushed the feat/circle-interop branch 10 times, most recently from 6eb9807 to fa3bad5 Compare June 5, 2019 11:33
@magik6k
Copy link
Member Author

magik6k commented Jun 5, 2019 •
edited
Loading

Not sure how to move forward on this, I'm getting

https://circleci.com/gh/ipfs/go-ipfs/16665

FetchError: request to https://dist.ipfs.io/go-ipfs/versions failed, reason: read ECONNRESET
Download failed!

Which might be related to some gateway problems.
This fixed itself now, so probably gateway related.

(Q: why is npm even checking the dist url when IPFS_GO_EXEC is set)

cc @alanshaw

@magik6k
Copy link
Member Author

magik6k commented Jun 5, 2019

This now runs interop tests, but it seems there are some errors - https://circleci.com/gh/ipfs/go-ipfs/16675

@magik6k magik6k marked this pull request as ready for review June 5, 2019 15:49
@magik6k magik6k requested a review from Stebalien June 5, 2019 15:49
Stebalien
Stebalien approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These appear to be working now. We can debug gateway issues separately.

Thanks!

@Stebalien Stebalien merged commit 5816f3c into master Jun 5, 2019
@hacdias hacdias deleted the feat/circle-interop branch May 9, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magik6k @Stebalien