New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: call app.Stop once #6380

Merged

Stebalien merged 1 commit into master from fix/app-stop-once

May 25, 2019

Member

magik6k commented May 25, 2019

This might help with #6356 as calling app.Stop twice in parallel could cause a lot of weird races (It may not though).

(If it will help with anything, it will be the mock repo part of the issue, context canceled is caused by 'wrong' use of contexts in MFS)


          core: call app.Stop once

7cfb4aa

magik6k requested a review from Stebalien

May 25, 2019 16:43

Stebalien approved these changes

View reviewed changes

Stebalien merged commit 9847416 into master

Member

Stebalien commented May 25, 2019

Thanks!

Stebalien deleted the fix/app-stop-once branch

May 25, 2019 17:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet