Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use http.Error for sending errors #6379

Merged
merged 1 commit into from
May 26, 2019
Merged

fix: use http.Error for sending errors #6379

merged 1 commit into from
May 26, 2019

Conversation

Stebalien
Copy link
Member

This sets a few headers that prevent browsers from misinterpreting the error text.

@Stebalien Stebalien requested a review from magik6k May 25, 2019 17:45
@Stebalien
fix: use http.Error for sending errors
23d3518 
This sets a few headers that prevent browsers from misinterpreting the error
text.
Stebalien
Stebalien commented May 26, 2019
View reviewed changes
Copy link
Member Author

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"self reviewed" with a fine-toothed comb (I want this in the release).

@Stebalien Stebalien merged commit 2b41ca1 into master May 26, 2019
@Stebalien Stebalien deleted the fix/http-errors branch July 3, 2019 14:11
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
@Stebalien
Merge pull request ipfs/kubo#6379 from ipfs/fix/http-errors
cc72040 
fix: use http.Error for sending errors

This commit was moved from ipfs/kubo@2b41ca1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k Awaiting requested review from magik6k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Stebalien