Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove out of date documentation #6345

Merged
merged 1 commit into from
May 17, 2019
Merged

doc: remove out of date documentation #6345

merged 1 commit into from
May 17, 2019

Conversation

Stebalien
Copy link
Member

No description provided.

@Stebalien
Copy link
Member Author

We need to do a code documentation pass eventually but this file is just confusing.

@Stebalien Stebalien requested a review from djdv May 16, 2019 23:25
djdv
djdv approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@djdv djdv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Text describing the sub packages, should be in those subpackages anyway.
Edit: Also, in regard to cyclical imports; I feel like the compiler will let you know, so it may be redundant to have it in the docs.

@Stebalien Stebalien merged commit 14ff3f9 into master May 17, 2019
@Stebalien Stebalien deleted the fix/5254 branch May 17, 2019 17:53
@Stebalien Stebalien restored the fix/5254 branch May 30, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djdv djdv djdv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @djdv