Support --human flag in cmd/object-stat #6241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikramsk
changed the title
--human flag in cmd/object-stat
Stebalien
approved these changes
Apr 21, 2019
- add support for printing CumulativeSize in human readable format. - add test to validate output. License: MIT Signed-off-by: Vikram Sreekumar <vikram1791@gmail.com>
vikramsk
force-pushed
the
fix/cmds/object-stat-human-flag
branch
from
97d969c
to
a7ed9d9
Compare
|
I added a test as well to the PR. Looks like 2 other tests failed in the sharness though. Not sure if my change caused that to break. Any help with this would be appreciated. |
|
No, unfortunately, those are just flaky. |
|
(merging as I doubt js-ipfs will object) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for printing the
CumulativeSizein theipfs object statcommand in a human readable form by using the--humanflag.Fixes #6226