Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix add error handling #6156

Merged
merged 3 commits into from
Mar 29, 2019
Merged

fix add error handling #6156

merged 3 commits into from
Mar 29, 2019

Conversation

Stebalien
Copy link
Member

  • Check dagservice commit errors on add.
  • Allow ipfs add --nocopy URL without enabling the filestore.

@Stebalien
handle errors from commit on add
337bf0f 
fixes #6139

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien requested a review from Kubuxu as a code owner March 29, 2019 11:54
@ghost ghost assigned Stebalien Mar 29, 2019
@ghost ghost added the status/in-progress In progress label Mar 29, 2019
@Stebalien
Copy link
Member Author

Broken out of #6140.

@Stebalien Stebalien mentioned this pull request Mar 29, 2019
Merged
@Stebalien
commands(add): fix ipfs add --nocopy URL without enabling the files…
470d6ba 
…tore

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
urlstore: test ipfs add --nocopy URL
21c0855 
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien requested a review from hsanjuan March 29, 2019 12:50
@Stebalien Stebalien merged commit 74d07ef into master Mar 29, 2019
@ghost ghost removed the status/in-progress In progress label Mar 29, 2019
@Stebalien Stebalien deleted the fix/6139 branch March 29, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@hsanjuan hsanjuan Awaiting requested review from hsanjuan

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @magik6k