Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only perform DNSLink lookups on fully qualified domain names (FQDN) #5950

Merged
merged 3 commits into from
Jan 29, 2019

Conversation

da2x
Copy link
Contributor

@da2x da2x commented Jan 28, 2019

This change halves the number of DNS queries required to lookup DNSLink information for "example.com" by forcing the use of a FQDN (e.g. example.com.).

  • example.com
  • example.com.local (removed)
  • _dnslink.example.com
  • _dnslink.example.com.local (removed)

Where .local is the local system's organization/domain name.

License: MIT
Signed-off-by: Daniel Aleksandersen

@da2x da2x requested a review from Kubuxu as a code owner January 28, 2019 06:32
This change halves the number of DNS queries requires to lookup DNSLink
information for "example.com" by forcing the use of a FQDN.

* example.com
* example.com.local (removed)
* _dnslink.example.com
* _dnslink.example.com.local (removed)

Where .local is the local system's organization/domain name.

License: MIT
Signed-off-by: Daniel Aleksandersen <code@daniel.priv.no>
License: MIT
Signed-off-by: Daniel Aleksandersen <code@daniel.priv.no>
License: MIT
Signed-off-by: Daniel Aleksandersen <code@daniel.priv.no>
@da2x
Copy link
Contributor Author

da2x commented Jan 28, 2019

I don’t beleive that the remaining failure is caused by the changes in this branch.

@Stebalien Stebalien added the RFM label Jan 29, 2019
@Stebalien Stebalien requested review from whyrusleeping and removed request for whyrusleeping January 29, 2019 18:31
@Stebalien
Copy link
Member

Yeah, /ipns/some.local.domain sounds like a really bad idea.

@Stebalien Stebalien merged commit 04fa5cf into ipfs:master Jan 29, 2019
@hoogw
Copy link

hoogw commented Feb 13, 2019

DNS bind ipns failure !!!!
I think this failure is related the issue in above post. Please advise.

working sample:

local gateway
http://127.0.0.1:8080/ipfs/QmcXbRoSrnmqwVFms3t9iX6DZMtKfUB9PJj6j8HQp59Ubj
http://127.0.0.1:8080/ipns/QmbX1mn42J9Fh7ascyaX2txtqRxRNFg3NWMXFr8k6HqKBj

publick gateway
https://ipfs.io/ipfs/QmcXbRoSrnmqwVFms3t9iX6DZMtKfUB9PJj6j8HQp59Ubj
https://ipfs.io/ipns/QmbX1mn42J9Fh7ascyaX2txtqRxRNFg3NWMXFr8k6HqKBj

Now I bind domain 'pdfbay.org' DNS txt record

@ means current domain pdfbay.org
TXT: type
1m: 1 second

@ | TXT | 1m | "dnslink=/ipns/QmbX1mn42J9Fh7ascyaX2txtqRxRNFg3NWMXFr8k6HqKBj"

Now the failure happened: (nothing shows)
http://localhost:8080/ipns/pdfbay.org
https://ipfs.io/ipns/pdfbay.org

By the way, on terminal, I try ipfs name resolve, it works fine:
https://ipfs.io/ipns/pdfbay.org

D:>ipfs name resolve -r pdfbay.org
/ipfs/QmcXbRoSrnmqwVFms3t9iX6DZMtKfUB9PJj6j8HQp59Ubj

Never Mind, after a few hours try again, delete DNS, try again,
It finally works.

The working DNSlink bind to domain pdfbay.org as

Note, Even you config correctly ,it need some time, may be up to 1 hours to have ipfs bind works,

http://localhost:8080/ipns/pdfbay.org
https://ipfs.io/ipns/pdfbay.org

@Stebalien
Copy link
Member

Stebalien commented Feb 13, 2019

It's not. Let's discussion the issue (#5992).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants