mfs: make sure to flush after mv and chcid #5936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Stebalien
commented
Jan 22, 2019
core/commands/files.go
Outdated
| return err | ||
| } | ||
| if flush { | ||
| return mfs.FlushPath(nd.FilesRoot, "/") |
There was a problem hiding this comment.
This does, in fact, work. We don't need to care about the individual files.
We need to call `FlushPath` as `Flush` doesn't call `WaitPub` internally. The correct fix is to rework MFS such that Flush actually flushes but that's a larger project. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
force-pushed
the
fix/mfs-flush
branch
from
920f5b1
to
e995397
Compare
magik6k
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to call
FlushPathasFlushdoesn't callWaitPubinternally. The correct fix is to rework MFS such that Flush actually flushes but that's a larger project.Fixes #5925 (comment) although I'm not sure what changed. In a followup PR, once ipfs/go-mfs#58 is merged, we can fix go-ipfs to run the teardown function before it cancels the context.