Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: flesh out plugin documentation #5876

Merged
merged 2 commits into from
Dec 27, 2018
Merged

docs: flesh out plugin documentation #5876

merged 2 commits into from
Dec 27, 2018

Conversation

Stebalien
Copy link
Member

  • Flesh out build documentation.
  • Add datastore plugins to plugin list.
  • Link to example plugin.
  • Add a TOC.

* Flesh out build documentation.
* Add datastore plugins to plugin list.
* Link to example plugin.
* Add a TOC.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost assigned Stebalien Dec 27, 2018
@ghost ghost added the status/in-progress In progress label Dec 27, 2018
Copy link
Contributor

@schomatis schomatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiicee. I always wanted to know more about our plugin system. 🎉

docs/plugins.md Outdated
| [flatfs](https://github.com/ipfs/go-ipfs/tree/master/plugin/plugins/flatfs) | Datastore | x | A stable filesystem-based datastore. |
| [levelds](https://github.com/ipfs/go-ipfs/tree/master/plugin/plugins/levelds) | Datastore | x | A stable, flexible datastore backend. |

* **Built-In** plugins are built into the go-ipfs binary and do not need to be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sound more like the deleted In-tree tag. Built-in gives me the impression they are already in the binary and do not need to be loaded at all.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are. I've tried to clarify that.


##### Other
### Preloaded Plugins
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "preloaded" mean in this context? (in contrast with the normal plugin, is it included in the binary?) What's the advantage with respect to just dropping it into the plugins dir?

docs/plugins.md Outdated

## Installing Plugins

External plugins must be installed in `$IPFS_PATH/plugins/` (usually
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph seems to be part of the subsequent External Plugin section.

myplugin$ go build -buildmode=plugin -i -o myplugin.so myplugin.go
```

Finally, as with in-tree plugins:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this seems pretty much the same as the previous install instructions (mkdir, copy, chmod, restart), maybe we can just point there if there is no substantial difference.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
Copy link
Member Author

@schomatis can you take another look? Trying to make the preload/external distinction clear.

Copy link
Contributor

@schomatis schomatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's clear now.

@Stebalien Stebalien merged commit 5a42289 into master Dec 27, 2018
@ghost ghost removed the status/in-progress In progress label Dec 27, 2018
@Stebalien Stebalien deleted the doc/plugin-stuff branch December 27, 2018 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants