startup: always load the private key #5844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading this at the last minute means we need a bunch of special cases in *every* command that needs routing, namesys, or even the public key. If we ever have a case where we don't want to do this, we can add an option to the (eventual) IPFS constructor. Handling this up-front is going to be significantly less error prone. Motivation: https://github.com/ipfs/go-ipfs/pull/5825/files#diff-fe35ea64d478c4f3fb767a3f618e5d01R863 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ghost
assigned License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
commented
Dec 13, 2018
| if cfg.Identity.PrivKey == "" { | ||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
This means we can still start without the private key.
There was a problem hiding this comment.
Might cause panics in some places, but that should only really affect tests
There was a problem hiding this comment.
I believe I've caught most places. Basically, everywhere we need the private key and would have otherwise called LoadPrivateKey or SetupOfflineRouting, we need to check if this is nil.
magik6k
approved these changes
Dec 13, 2018
| if cfg.Identity.PrivKey == "" { | ||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
Might cause panics in some places, but that should only really affect tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading this at the last minute means we need a bunch of special cases in every command that needs routing, namesys, or even the public key.
If we ever have a case where we don't want to do this, we can add an option to the (eventual) IPFS constructor. Handling this up-front is going to be significantly less error prone.
Motivation: https://github.com/ipfs/go-ipfs/pull/5825/files#diff-fe35ea64d478c4f3fb767a3f618e5d01R863