Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md link #5811

Merged
merged 1 commit into from
Dec 3, 2018
Merged

CONTRIBUTING.md link #5811

merged 1 commit into from
Dec 3, 2018

Conversation

nuke-web3
Copy link
Member

No description provided.

@nuke-web3
Copy link
Member Author

@Kubuxu - sorry to ping you on this. It is just a minor patch to a bad link in README.md

And now a bad link in the GitCop too 😉

Can you help?

@kevina
Copy link
Contributor

kevina commented Dec 3, 2018

License: MIT
Signed-off-by: Dan Shields <danwshields@gmail.com>
@nuke-web3
Copy link
Member Author

@nukemandan see https://github.com/ipfs/community/blob/master/CONTRIBUTING.md#a-license-and-a-signed-off-by-trailers-are-required we need to fix the GitCop link.

do I need to raise another issue for the cop?

Ironic - in the link you sent, this is broken 🤦‍♂️
https://github.com/ipfs/community/blob/master/docs/amending-commits.md

@Stebalien Stebalien merged commit 481136b into ipfs:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants