Switch to using request.Context() #5782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
ghost
assigned 
Stebalien
approved these changes
Nov 19, 2018
|
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
Switch to using request.Context() This commit was moved from ipfs/kubo@ebc7cdc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was looking through the http handler code. When we figured out this CloseNotify stuff initially, I remember being super excited. That was quite some time ago, things have gotten better since then. The request.Context() now will cancel when the client leaves, or when the http server is shutdown, which is exactly what we want here.
This approach also frees us from having to run another extra goroutine. Yay.
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com