cmds/env: add a config path helper #5712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevina
reviewed
Nov 1, 2018
core/commands/cmdenv/env.go
Outdated
| @@ -40,3 +40,13 @@ func GetConfig(env cmds.Environment) (*config.Config, error) { | |||
|
|
|||
| return ctx.GetConfig() | |||
| } | |||
|
|
|||
| // GetConfigPath extracts the config path from the environment | |||
| func GetConfigPath(env cmds.Environment) (string, error) { | |||
There was a problem hiding this comment.
I would name this GetConfigRoot, to be consistent with the variable it is accessing. I agree it not the best name, but I think it better to be consistent here.
There was a problem hiding this comment.
@kevina Changed it.
overbool
force-pushed
the
feat/cmds/add-config-helper
branch
from
92a06e5
to
33019df
Compare
License: MIT Signed-off-by: Overbool <overbool.xu@gmail.com>
overbool
force-pushed
the
feat/cmds/add-config-helper
branch
from
33019df
to
bf15999
Compare
kevina
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Overbool overbool.xu@gmail.com