Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(cmd/verify): add goroutine count to improve verify speed #5710

Merged
merged 1 commit into from
Nov 2, 2018
Merged

enhance(cmd/verify): add goroutine count to improve verify speed #5710

merged 1 commit into from
Nov 2, 2018

Conversation

qiwaa
Copy link
Contributor

@qiwaa qiwaa commented Oct 31, 2018

refs: #5696

License: MIT
Signed-off-by: chenminjian 727180553@qq.com

@qiwaa qiwaa requested a review from Kubuxu as a code owner October 31, 2018 13:23
@qiwaa
Copy link
Contributor Author

qiwaa commented Oct 31, 2018

hey, @Stebalien . I use Ctrl + C to interrupt ipfs repo verify, then IPFS panic: send on closed channel. It looks like we can't use goroutine and select simply. I am going to use sync.WaitGroup to avoid it. Does that make sense? Can you give me some advice? Thx a lot.

overbool
overbool reviewed Oct 31, 2018
View reviewed changes
core/commands/repo.go Outdated Show resolved Hide resolved
Stebalien
Stebalien reviewed Oct 31, 2018
View reviewed changes
core/commands/repo.go Outdated Show resolved Hide resolved
@qiwaa qiwaa changed the title [WIP] enhance(cmd/verify): add goroutine count to add verify speed enhance(cmd/verify): add goroutine count to improve verify speed Nov 2, 2018
Stebalien
Stebalien approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiwaa @Stebalien
enhance(cmd/verify): add goroutine count to improve verify speed
17e7892 
License: MIT
Signed-off-by: chenminjian <727180553@qq.com>
@ghost ghost assigned Stebalien Nov 2, 2018
@ghost ghost added the status/in-progress In progress label Nov 2, 2018
@Stebalien Stebalien merged commit 11978f5 into ipfs:master Nov 2, 2018
@ghost ghost removed the status/in-progress In progress label Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overbool overbool overbool left review comments

@Stebalien Stebalien Stebalien approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qiwaa @Stebalien @overbool