namesys: properly attach path in name.Resolve #5660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
djdv
reviewed
Oct 26, 2018
core/coreapi/name_test.go
Outdated
| ctx := context.Background() | ||
| nds, apis, err := makeAPISwarm(ctx, true, 5) | ||
| func appendPath(path coreiface.Path, sub string) coreiface.Path { | ||
| p, err := coreiface.ParsePath(path.String() + sub) |
There was a problem hiding this comment.
Even though it will result in the same behaviour, I wonder if we should make a point to use path.Join in these instances.
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
magik6k
force-pushed
the
fix/resolve-paths
branch
from
2ca560c
to
f4e5625
Compare
magik6k
added
kind/bug
Stebalien
approved these changes
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got broken in the async namesys refactor, somehow there were no tests to catch this.