Dockerfile: Specifies comments on exposed ports #5615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
previously approved these changes
Oct 22, 2018
Stebalien
requested changes
Oct 23, 2018
Dockerfile
Outdated
| EXPOSE 8080 | ||
| # Swarm Websockets; must be exposed publilcy when websocket transfer is enabled |
There was a problem hiding this comment.
This is the websocket transport. That is, you can listen on /ip4/0.0.0.0/tcp/8081/ws to accept connections from peers (usually browsers) using the websocket libp2p transport.
There was a problem hiding this comment.
could you provide a proposal for the wording? (there's that new cool feature here on gh.) i don't fully get what your response means regarding my proposal.
Stebalien
reviewed
Oct 23, 2018
Closes #5610 License: MIT Signed-off-by: Frank Sachsenheim <funkyfuture@noreply.github.com>
Stebalien
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr addresses #5610. i have no clue what websocket transfer is in this context, that part may be very wrong.