add offline id test #4978 and refactor command code #5562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eingenito
approved these changes
Oct 4, 2018
| @@ -25,7 +29,7 @@ Lists running and recently run commands. | |||
| res.SetOutput(req.InvocContext().ReqLog.Report()) | |||
| }, | |||
| Options: []cmdkit.Option{ | |||
| cmdkit.BoolOption("verbose", "v", "Print extra information."), | |||
| cmdkit.BoolOption("verbose", verboseOptionName, "Print extra information."), | |||
There was a problem hiding this comment.
We might want to switch this to constantize (and later use in req.Option()) the long name for this command so that it is consistent with all the others.
Stebalien
approved these changes
Oct 5, 2018
|
LGTM but let's wait to merge #5501 first (this patch will be easier to rebase/redo). |
Stebalien
added
the
status/blocked
License: MIT Signed-off-by: Kejie Zhang <601172892@qq.com>
License: MIT Signed-off-by: Kejie Zhang <601172892@qq.com>
License: MIT Signed-off-by: Kejie Zhang <601172892@qq.com>
Stebalien
removed
the
status/blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #4978