fix(unixfs): issue #5217 (Avoid use of pb.Data)
#5505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevina
changed the title
pb.Data)
|
@overbool what about removing the |
overbool
force-pushed
the
fix/issue-#5217
branch
from
089622b
to
a4c30f2
Compare
|
I'm sorry, I misspoken. Is it possible to just delete the The added commented are not really necessary and in my opinion are just adding noise. Others may disagree with me though. |
License: MIT Signed-off-by: Overbool <overbool.xu@gmail.com>
overbool
force-pushed
the
fix/issue-#5217
branch
from
a4c30f2
to
48c3eff
Compare
|
@kevina @schomatis I had done a similar replacement for here ipfs/go-unixfs#18, ipfs/go-mfs#7 and remove Could u help me review it? |
schomatis
approved these changes
Sep 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Overbool overbool.xu@gmail.com
Fixes: #5217