don't bother caching if we're using a nil repo #5414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(it'll be wrong anyways) License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ghost
assigned
Stebalien
commented
Aug 31, 2018
| } | ||
|
|
||
| wbs = bstore.NewIdStore(wbs) | ||
| bs = bstore.NewIdStore(bs) |
There was a problem hiding this comment.
I renamed this (made it slightly harder to disable caching). Any reason it was wbs?
|
@Stebalien what's the motivation for this change. When is a nil repo used? |
When adding files with |
kevina
approved these changes
Aug 31, 2018
|
The main reasons are:
In practice, given where we use the nil repo, this really shouldn't make much of a difference (maybe a slight performance gain). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(it'll be wrong anyways)