gx update go-log, sys, go-crypto #5100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
* go-log * sys * go-crypto License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
force-pushed
the
gx/update-stuff
branch
from
6ed589d
to
85acad9
Compare
Stebalien
added
need/review
Stebalien
commented
Jun 9, 2018
| @@ -105,7 +106,7 @@ Outputs event log messages (not other log messages) as they are generated. | |||
| defer w.Close() | |||
| <-ctx.Done() | |||
| }() | |||
| logging.WriterGroup.AddWriter(w) | |||
| lwriter.WriterGroup.AddWriter(w) | |||
Stebalien
commented
Jun 9, 2018
| @@ -49,7 +49,7 @@ func LogOption() ServeOption { | |||
| mux.HandleFunc("/logs", func(w http.ResponseWriter, r *http.Request) { | |||
| w.WriteHeader(200) | |||
| wnf, errs := newWriteErrNotifier(w) | |||
| logging.WriterGroup.AddWriter(wnf) | |||
| lwriter.WriterGroup.AddWriter(wnf) | |||
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
gx update go-log, sys, go-crypto This commit was moved from ipfs/kubo@08fb11f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for updating go-net (easier to do in two separate gx-workspace
updates) so we can move forward on libp2p/go-libp2p#285.