only resolve dnslinks once in the gateway #4977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should add tests but testing DNS is a bit tricky. Thoughts? |
magik6k
reviewed
Apr 25, 2018
There was a problem hiding this comment.
LGTM
I think it's possible to write a test for this - see https://github.com/ipfs/go-ipfs/blob/master/core/corehttp/gateway_test.go#L132
|
@magik6k thanks! This now has tests. |
Stebalien
added
need/review
magik6k
approved these changes
Apr 25, 2018
core/corehttp/ipns_hostname.go
Outdated
| @@ -7,6 +7,7 @@ import ( | |||
| "strings" | |||
|
|
|||
| "github.com/ipfs/go-ipfs/core" | |||
| opts "github.com/ipfs/go-ipfs/namesys/opts" | |||
There was a problem hiding this comment.
Either drop prefix or add to the import above too
Kubuxu
approved these changes
Apr 26, 2018
If the domain has a DNS-Link, we want to use it even if it points to, e.g., an IPNS address that doesn't resolve. fixes #4973 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ghost
pushed a commit
that referenced
this pull request
Jul 7, 2018
A while ago, we noticed that if IpnsHostname failed to look up a dnslink for a hostname in a Host header, it wouldn't respond with an error, but instead just skip the Host header part and carry on. In the issue were this was flagged, the example was: `_dnslink.tr.wikipedia-on-ipfs.org => /ipns/QmSomeKey` This key had stopped to resolve, and thus the resolution of /ipns/tr.wikipedia-on-ipfs.org would fail. Now you'd expect an error response, but instead it'd happily continue processing the request, disregarding the Host header, and allowing requests to e.g. http://tr.wikipedia-on-ipfs.org/ipns/libp2p.io to succeed. A previous patch (#4977) tried to work around this issue by limiting the recursion depth of Host: header dnslink resolutions to 1. In this patch we start to correctly handle the initial resolution error and stop processing the request, and we remove the earlier workaround. License: MIT Signed-off-by: Lars Gierth <larsg@systemli.org>
ghost
mentioned this pull request
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
only resolve dnslinks once in the gateway This commit was moved from ipfs/kubo@f7a9809
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the domain has a DNS-Link, we want to use it even if it points to, e.g., an IPNS address that doesn't resolve.
fixes #4973