make the tar writer handle sharded ipfs directories #4873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes ipfs get work on sharded directories fixes #4871 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Unfortunately, fixing this would require breaking the API. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ghost
assigned License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ghost
approved these changes
Mar 24, 2018
| case unixfspb.Data_HAMTShard: | ||
| // We need a streaming ls API for this. | ||
| res.SetError(fmt.Errorf("cannot list large directories yet"), cmdkit.ErrNormal) | ||
| return |
There was a problem hiding this comment.
I think it would be okay to have this without a streaming ls. It's just gonna take its time to run, just like dir-listings on the gateway for sharded directories.
The streaming ls is an optimization (an important one nevertheless).
There was a problem hiding this comment.
Fine by me (although let's fix that in a different PR #4874).
daviddias
approved these changes
Mar 25, 2018
|
I'll review it when I get back to my computer. |
whyrusleeping
approved these changes
Mar 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes ipfs get work on sharded directories.
fixes #4871