Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 4864 #4865

Merged
merged 1 commit into from
Mar 25, 2018
Merged

Fix 4864 #4865

merged 1 commit into from
Mar 25, 2018

Conversation

steverecio
Copy link
Contributor

@steverecio steverecio commented Mar 22, 2018 •
edited
Loading

Resolves #4864 (Removes broken "Todo" link in README)

@steverecio steverecio requested a review from Kubuxu as a code owner March 22, 2018 21:11
@Stebalien
Copy link
Member

LGTM modulo the GitCop warning.

Kubuxu
Kubuxu approved these changes Mar 23, 2018
View reviewed changes
Copy link
Member

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just doc change, so I think no need for required sign-off but it wouldn't hurt.

@steverecio
Copy link
Contributor Author

FYI the contribution guidelines link in the gitcop message is outdated (new link is here afaik)

@steverecio steverecio force-pushed the fix/4864 branch 3 times, most recently from b9a418c to 4f92a69 Compare March 25, 2018 20:03
@steverecio
Remove broken todo link in readme (resolves ipfs#4864)
1fb27c9 
License: MIT
Signed-off-by: Steve Recio <srecio@cs.stanford.edu>
@whyrusleeping whyrusleeping merged commit 4edcebb into ipfs:master Mar 25, 2018
@whyrusleeping
Copy link
Member

Thanks @steverecio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Kubuxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steverecio @Stebalien @whyrusleeping @Kubuxu