misc: Remove some dead code #4833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
reviewed
Mar 19, 2018
core/commands/pin.go
Outdated
| @@ -539,7 +539,7 @@ func pinLsKeys(args []string, typeStr string, ctx context.Context, n *core.IpfsN | |||
| return keys, nil | |||
| } | |||
|
|
|||
| func pinLsAll(typeStr string, ctx context.Context, n *core.IpfsNode) (map[string]RefKeyObject, error) { | |||
| func pinLsAll(typeStr string, n *core.IpfsNode) (map[string]RefKeyObject, error) { | |||
There was a problem hiding this comment.
Instead of removing this context, I'd use it and pass it to the EnumerateChildren call.
| ipld "gx/ipfs/Qme5bWv7wtjUNGsK2BNGVUFPKiuxWrsqrtvYwCLRw8YFES/go-ipld-format" | ||
|
|
||
| bal "github.com/ipfs/go-ipfs/importer/balanced" | ||
| h "github.com/ipfs/go-ipfs/importer/helpers" | ||
| trickle "github.com/ipfs/go-ipfs/importer/trickle" | ||
| ) | ||
|
|
||
| // BuildDagFromFile builds a DAG from the given file, writing created blocks to | ||
| // disk as they are created. | ||
| func BuildDagFromFile(fpath string, ds ipld.DAGService) (ipld.Node, error) { |
There was a problem hiding this comment.
While not currently used, I wouldn't necessarily delete this. It's not that much code and may be useful.
On the other hand... stating and then opening is racy.
unixfs/test/utils.go
Outdated
| @@ -104,32 +102,3 @@ func ArrComp(a, b []byte) error { | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| // PrintDag pretty-prints the given dag to stdout. | |||
| func PrintDag(nd *mdag.ProtoNode, ds ipld.DAGService, indent int) { | |||
There was a problem hiding this comment.
I'd leave this. Looks useful for debugging.
magik6k
force-pushed
the
misc/remove-dead-code
branch
from
1250882
to
79d35ba
Compare
Kubuxu
reviewed
Mar 19, 2018
core/commands/filestore.go
Outdated
| cmds "gx/ipfs/QmabLouZTZwhfALuBcssPvkzhbYGMb4394huT7HY4LQ6d3/go-ipfs-cmds" | ||
| cid "gx/ipfs/QmcZfnkapfECQGcLZaf9B79NRg7cRa9EnZh4LSbkCzwNvY/go-cid" | ||
| "gx/ipfs/QmceUdzxkimdYsgtX733uNgzf1DLHyBKN6ehGSp85ayppM/go-ipfs-cmdkit" | ||
|
|
||
| lgc "github.com/ipfs/go-ipfs/commands/legacy" |
magik6k
force-pushed
the
misc/remove-dead-code
branch
2 times, most recently
from
482fb2a
to
028bc03
Compare
Stebalien
approved these changes
Mar 20, 2018
|
Will need to be merged last and rebased (conflicts) |
Kubuxu
added
RFM
status/blocked
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
magik6k
force-pushed
the
misc/remove-dead-code
branch
from
028bc03
to
bfdfb8d
Compare
|
rebased |
Kubuxu
approved these changes
Mar 23, 2018
Kubuxu
added
RFM
status/blocked
|
What is this blocked on? |
|
It was blocked to prevent merge conflicts. |
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Apr 7, 2022
misc: Remove some dead code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.