Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use prefix in bootstrapWritePeers #4832

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Use prefix in bootstrapWritePeers #4832

merged 1 commit into from
Mar 23, 2018

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Mar 19, 2018

This is probably what should happen here.

@magik6k magik6k requested a review from Kubuxu as a code owner March 19, 2018 00:06
@ghost ghost assigned magik6k Mar 19, 2018
@ghost ghost added the status/in-progress In progress label Mar 19, 2018
@magik6k
use prefix in bootstrapWritePeers
ed54f58 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
Stebalien
Stebalien approved these changes Mar 19, 2018
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably

Kubuxu
Kubuxu approved these changes Mar 19, 2018
View reviewed changes
Copy link
Member

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kubuxu Kubuxu added RFM and removed status/in-progress In progress labels Mar 19, 2018
@Kubuxu Kubuxu added this to the go-ipfs 0.4.15 milestone Mar 19, 2018
@whyrusleeping whyrusleeping merged commit 6b180b2 into master Mar 23, 2018
@whyrusleeping
Copy link
Member

That one seems like an oooold bug. Nice work.

@whyrusleeping whyrusleeping deleted the fix/bootstrap-cmd-prefix branch March 23, 2018 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@Kubuxu Kubuxu Kubuxu approved these changes

Assignees

@magik6k magik6k

Labels
RFM
Projects
None yet
Milestone
go-ipfs 0.4.15
Development

Successfully merging this pull request may close these issues.
4 participants
@magik6k @whyrusleeping @Stebalien @Kubuxu