Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error style for most errors #4829

Merged
merged 1 commit into from
Mar 30, 2018
Merged

Fix error style for most errors #4829

merged 1 commit into from
Mar 30, 2018

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Mar 18, 2018

No description provided.

@magik6k magik6k requested a review from Kubuxu as a code owner March 18, 2018 18:56
@ghost ghost assigned magik6k Mar 18, 2018
@ghost ghost added the status/in-progress In progress label Mar 18, 2018
Kubuxu
Kubuxu approved these changes Mar 18, 2018
View reviewed changes
Copy link
Member

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but merge it last, after most PRs waiting for 0.4.14 release are merged.

This has possibility of creating a lot of merge conflicts.

@Kubuxu Kubuxu added RFM status/blocked Unable to be worked further until needs are met and removed status/in-progress In progress labels Mar 18, 2018
@Kubuxu Kubuxu added this to the go-ipfs 0.4.15 milestone Mar 18, 2018
@whyrusleeping
Copy link
Member

I think we can probably merge this one now. Wanna rebase @magik6k ?

@magik6k
fix error style
2ee5cfb 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@ghost ghost added the status/in-progress In progress label Mar 30, 2018
@magik6k
Copy link
Member Author

magik6k commented Mar 30, 2018

Rebased

@magik6k magik6k removed the status/blocked Unable to be worked further until needs are met label Mar 30, 2018
@Kubuxu Kubuxu removed the status/in-progress In progress label Mar 30, 2018
@whyrusleeping whyrusleeping merged commit ecb4095 into master Mar 30, 2018
@whyrusleeping whyrusleeping deleted the fix/error-style branch March 30, 2018 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@Kubuxu Kubuxu Kubuxu approved these changes

Assignees

@magik6k magik6k

Labels
RFM
Projects
None yet
Milestone
go-ipfs 0.4.15
Development

Successfully merging this pull request may close these issues.
4 participants
@magik6k @whyrusleeping @Stebalien @Kubuxu