Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make init command use go-ipfs-cmds #4732

Merged
merged 1 commit into from
Mar 23, 2018
Merged

make init command use go-ipfs-cmds #4732

merged 1 commit into from
Mar 23, 2018

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Feb 23, 2018

Hello!
Wanted to start contributing, so first I've a changed initCmd, so that it uses now new interface from go-ipfs-cmds.

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kubuxu Kubuxu added the RFM label Mar 9, 2018
@Kubuxu Kubuxu added this to the go-ipfs 0.4.15 milestone Mar 9, 2018
@whyrusleeping
Copy link
Member

@fyrchik Thanks for the PR! Now that 0.4.14 has shipped, its merging time. This one just needs a rebase, mind doing that for us?

License: MIT
Signed-off-by: Evgenii Stratonikov <kraunid@gmail.com>
@fyrchik
Copy link
Contributor Author

fyrchik commented Mar 23, 2018

@whyrusleeping Done! Touched only imports.

@whyrusleeping whyrusleeping merged commit 174053e into ipfs:master Mar 23, 2018
@whyrusleeping
Copy link
Member

Thanks @fyrchik :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants