Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: golint-ify path package. #4689

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Doc: golint-ify path package. #4689

merged 1 commit into from
Feb 13, 2018

Conversation

hsanjuan
Copy link
Contributor

This removes all go-lint warnings in the path package.

This removes all go-lint warnings in the path package.

License: MIT
Signed-off-by: Hector Sanjuan <hector@protocol.ai>
@hsanjuan hsanjuan self-assigned this Feb 12, 2018
@hsanjuan hsanjuan requested a review from a user February 12, 2018 21:23
@ghost ghost added the status/in-progress In progress label Feb 12, 2018
@hsanjuan
Copy link
Contributor Author

By the way, I will be extracting this too

@ghost
Copy link

ghost commented Feb 12, 2018

By the way, I will be extracting this too

Have you synced with @Stebalien? It's part of the IPLD extraction/disentanglement

@Stebalien
Copy link
Member

@lgierth this package actually covers IPFS path resolution as well (the resolver is pluggable, technically).

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@whyrusleeping whyrusleeping merged commit e5f80fa into master Feb 13, 2018
@ghost ghost removed the status/in-progress In progress label Feb 13, 2018
@whyrusleeping
Copy link
Member

👏 👏

@whyrusleeping whyrusleeping deleted the doc/golint-path branch February 13, 2018 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants