Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document make targets #4653

Merged
merged 3 commits into from
Feb 7, 2018
Merged

document make targets #4653

merged 3 commits into from
Feb 7, 2018

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Feb 4, 2018 •
edited by kevina
Loading

Closes #4647.

@Stebalien
document make targets
30b8fa0 
fixes #4647

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
remove useless make target
0e8fc8f 
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost assigned Stebalien Feb 4, 2018
@ghost ghost added the status/in-progress In progress label Feb 4, 2018
@Stebalien Stebalien requested a review from kevina February 4, 2018 14:13
whyrusleeping
whyrusleeping reviewed Feb 4, 2018
View reviewed changes
test/sharness/Rules.mk
@@ -60,9 +60,6 @@ test_sharness_expensive: export TEST_EXPENSIVE=1
test_sharness_expensive: test_sharness_short
.PHONY: test_sharness_expensive

test_sharness_race: GOFLAGS += -race
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this going away?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't do anything.

kevina
kevina reviewed Feb 5, 2018
View reviewed changes
Copy link
Contributor

@kevina kevina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unclear what if the test_go_race target runs all the tests or just the short ones. It is also not really needed. I would remove it and document to enable race detection use something like GOFLAGS=-race make test_go_expensive or if this is used with out automatic testing just document it.

@whyrusleeping
Copy link
Member

Can we figure out the random test failures and make issues for them? Its starting to get uncomfortable.

@Stebalien
Copy link
Member Author

@whyrusleeping the jenkins one looks like a jenkins reboot.

The travis one looks like an issue with error handling in the commands library: #4670.

@Stebalien
document test_go_test make target
5abb3c6 
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
Copy link
Member Author

It is unclear what if the test_go_race target runs all the tests or just the short ones. It is also not really needed. I would remove it and document to enable race detection use something like GOFLAGS=-race make test_go_expensive or if this is used with out automatic testing just document it.

Let's do that later.

@whyrusleeping whyrusleeping merged commit f0289e5 into master Feb 7, 2018
@whyrusleeping whyrusleeping deleted the fix/4647 branch February 7, 2018 20:38
@ghost ghost removed the status/in-progress In progress label Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping left review comments

@kevina kevina kevina approved these changes

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stebalien @whyrusleeping @kevina