Docs: golint-ify "importers" module #4640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes all golint warnings in the importers module, adding documentation and module descriptions. License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
ghost
added
the
hsanjuan
commented
Feb 1, 2018
| // Layout builds a balanced DAG. Data is stored at the leaves | ||
| // and depth only increases when the tree is full, that is, when | ||
| // the root node has reached the maximum number of links. | ||
| func Layout(db *h.DagBuilderHelper) (ipld.Node, error) { |
There was a problem hiding this comment.
Be aware there are two or three API changes due to stuttering.
There was a problem hiding this comment.
Does golint complain about stuttering or is that just a personal preference?
There was a problem hiding this comment.
It complains about it
I changed it unnoticedly. License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all golint warnings in the importers module, adding
documentation and module descriptions.
License: MIT
Signed-off-by: Hector Sanjuan hector@protocol.ai