Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WebUI version #4449

Merged
merged 2 commits into from
Dec 4, 2017
Merged

Update WebUI version #4449

merged 2 commits into from
Dec 4, 2017

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Dec 2, 2017

That ^ /cc @diasdavid

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's still really flaky (need to constantly reload to get things working) but seems to work better than it did before.

@hacdias
Copy link
Member Author

hacdias commented Dec 2, 2017

@Stebalien, despite the Connections page, where are you having issues? 😄

@Stebalien
Copy link
Member

I think it was just lag introduced by the connections page. That is, I'd open the connections page and then try to switch to the Home page and it wouldn't show anything (although, on further testing, it's just really slow).

I also couldn't get it to create a directory in the Files page on my first try but I can't reproduce that.

@hacdias
Copy link
Member Author

hacdias commented Dec 2, 2017

@Stebalien yeah, the Conns page is very laggy and buggy. I really want to change that as you know.

@whyrusleeping
Copy link
Member

@hacdias hrm... either it doesnt work in firefox, or it doesnt work with the ipfs-companion extension. I get the following error message:
screen shot 2017-12-03 at 9 10 11 am

@Stebalien
Copy link
Member

Do you not get that second error with the current WebUI? IIRC, the companion redirects any URL starting with /ipfs/QmId... to the local gateway (which would cause the webui to be served from the local gateway instead of the local API, causing cors issues).

However, I can confirm that the connections page is broken on Firefox. Here's a stacktrace (FWIW, the JS is compressed).

TypeError: e is null
Stack trace:
get@http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/ipfs-webui.0.3.0.js:1:2502288
n@http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/ipfs-webui.0.3.0.js:1:2502166
tt@http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/ipfs-webui.0.3.0.js:1:2529702
t.default/<@http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/ipfs-webui.0.3.0.js:1:2432989
t.default@http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/ipfs-webui.0.3.0.js:1:2432111
value@http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/ipfs-webui.0.3.0.js:1:2428299
value@http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/ipfs-webui.0.3.0.js:1:2427636
commitLifeCycles@http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/ipfs-webui.0.3.0.js:1:864589
t@http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/ipfs-webui.0.3.0.js:1:851042
E@http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/ipfs-webui.0.3.0.js:1:856513
_@http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/ipfs-webui.0.3.0.js:1:856214
h@http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/ipfs-webui.0.3.0.js:1:855346
p@http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/ipfs-webui.0.3.0.js:1:854739
updateContainer@http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/ipfs-webui.0.3.0.js:1:867378
Jt/<@http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/ipfs-webui.0.3.0.js:1:879185
unbatchedUpdates@http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/ipfs-webui.0.3.0.js:1:865873
Jt@http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/ipfs-webui.0.3.0.js:1:879154
render@http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/ipfs-webui.0.3.0.js:1:909256
@http://localhost:5001/ipfs/QmQLXHs7K98JNQdWrBB2cQLJahPhmupbDjRuH1b9ibmwVa/ipfs-webui.0.3.0.js:1:771231
 ipfs-webui.0.3.0.js:1:854273

@hacdias
Copy link
Member Author

hacdias commented Dec 4, 2017

@Stebalien strange... every page is working on my computer on Firefox. (I'm using npm run start directly from the repo).

@daviddias
Copy link
Member

daviddias commented Dec 4, 2017

@Stebalien double check to see if you were using the latest released go-ipfs

@whyrusleeping
Copy link
Member

@hacdias ah, it was the ipfs-companion redirect. @lidel can you take a look at this?

@lidel
Copy link
Member

lidel commented Dec 4, 2017

Yup, its is the same issues as described in ipfs/ipfs-companion#291
I'll bump the priority and fix it shortly.

Workaround for now: replace localhost:5001 with 127.0.0.1:5001 (API URL in browser extension Preferences)

@whyrusleeping whyrusleeping merged commit 6104cfd into ipfs:master Dec 4, 2017
@whyrusleeping
Copy link
Member

Thanks @lidel!

@whyrusleeping
Copy link
Member

Also, thank you @hacdias for all the fixes :)

@hacdias
Copy link
Member Author

hacdias commented Dec 4, 2017

It was a pleasure!

@daviddias
Copy link
Member

Woooooot! :D

@Stebalien
Copy link
Member

Stebalien commented Dec 4, 2017

double check to see if you were using the latest released go-ipfs

It's because I've disabled webgl in Firefox (it's a large attack surface). Nevermind. (ipfs/ipfs-webui#320)

@hacdias
Copy link
Member Author

hacdias commented Dec 4, 2017

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants