Refine gateway and namesys logging #4428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Filed #4429 for the CircleCI failure, and the first TravisCI failure is related to ongoing gateway issues. |
Kubuxu
approved these changes
Nov 26, 2017
Stebalien
reviewed
Nov 26, 2017
| @@ -510,7 +506,6 @@ func (i *gatewayHandler) putHandler(w http.ResponseWriter, r *http.Request) { | |||
| return | |||
| } | |||
| default: | |||
| log.Warningf("putHandler: unhandled resolve error %T", ev) | |||
There was a problem hiding this comment.
If this is a user error, we shouldn't be returning a 502. If it is, we should log it.
There was a problem hiding this comment.
Mh yes indeed - I'll cover this in the upcoming gateway+coreapi PR.
ghost
force-pushed
the
feat/namesys-logging
branch
2 times, most recently
from
7f63458
to
1046294
Compare
whyrusleeping
approved these changes
Dec 1, 2017
|
needs a rebase |
added 2 commits
December 7, 2017 00:21
License: MIT Signed-off-by: Lars Gierth <larsg@systemli.org>
License: MIT Signed-off-by: Lars Gierth <larsg@systemli.org>
ghost
force-pushed
the
feat/namesys-logging
branch
from
1046294
to
55692ac
Compare
|
@whyrusleeping rebased |
whyrusleeping
approved these changes
Dec 7, 2017
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
Refine gateway and namesys logging This commit was moved from ipfs/kubo@4d41235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signal/noise ratio on the ipfs.io gateways is incredibly bad nowadays - this is a step to improving that.
All the logs here are based on user input, and they're neither WARN nor INFO worthy, so I'm degrading them all to DEBUG. Also removed a few useless log lines.
I'm already testing this on scrappy, where the logs are now actually readable.