Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hamt delete issue #4398

Merged
merged 3 commits into from
Dec 5, 2017
Merged

fix hamt delete issue #4398

merged 3 commits into from
Dec 5, 2017

Conversation

whyrusleeping
Copy link
Member

Found this while writing another hamt (using ipld :) )

License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com

License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
@ghost ghost assigned whyrusleeping Nov 18, 2017
@ghost ghost added the status/in-progress In progress label Nov 18, 2017
@Stebalien Stebalien self-requested a review November 18, 2017 20:16
Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -2,6 +2,7 @@ package hamt

import (
"math/big"
"math/bits"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are adding this we should increase checked Go version to 1.9 in package.json and Makefiles.

License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
Copy link
Member

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think LGTM but HAMT code is a bit of mystery to me.

@Stebalien Stebalien mentioned this pull request Dec 5, 2017
5 tasks
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the best of my understanding, this looks right.

@whyrusleeping whyrusleeping merged commit bbdbd0a into master Dec 5, 2017
@whyrusleeping whyrusleeping deleted the fix/hamt-bug branch December 5, 2017 19:53
@ghost ghost removed the status/in-progress In progress label Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants