Do not publish public keys extractable from ID #4020
Conversation
There was a problem hiding this comment.
@JustinDrake these changes look good to me, and all the required deps have now been updated (in #4059). Last thing I'd like to see before merging this is a test or two showing that using an ed25519 key doesnt publish to the dht.
|
(you'll want to rebase on latest master to make it all work) |
|
@whyrusleeping I've rebased. How do you suggest that the test be written? There are no tests for |
|
@vyzo could you help @JustinDrake out with some tests here? |
|
@JustinDrake we can add a publisher_test.go file. We can start with a simple test which directly tests the behaviour of The side-effect of |
|
Note that you can mock the network and even the value store. |
|
@vyzo Thank you for the suggestions of using the value store, and of testing both the RSA and Ed25519 cases. @whyrusleeping I now have a test that shows that an Ed25519 key does not publish to the DHT, and (bonus) a test that shows that an RSA key does publish to the DHT. |
namesys/publisher.go
Outdated
| errs := make(chan error, 2) // At most two errors (IPNS, and public key) | ||
|
|
||
| // Attempt to extract the public key from the ID | ||
| var extractedPublicKey = id.ExtractPublicKey() |
There was a problem hiding this comment.
nitpick: extractedPublicKey := ... instead of using var
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
|
|
There was a problem hiding this comment.
for completeness sake, it might be good to check in the dstore to make sure theres no key being put there.
License: MIT Signed-off-by: Justin Drake <drakefjustin@gmail.com>
|
Is this good to merge? :) |
|
Thanks @JustinDrake! |
License: MIT
Signed-off-by: Justin Drake drakefjustin@gmail.com