check strong and weak ETag validator #3983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code LGTM (although you should try to make the bots a bit happier if possible (I don't think you'll be able to make travis happy)). |
|
looks like its failing a formatting check. Make sure to run gofmt on your code |
CDN may change strong ETag validator to weak ETag validator. License: MIT Signed-off-by: Ivan <ivan386@users.noreply.github.com>
|
In addition to what gitcop says, please squash these commits into a single commit. |
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
check strong and weak ETag validator This commit was moved from ipfs/kubo@a234c56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDN may change strong ETag validator to weak ETag validator.
License: MIT
Signed-off-by: Ivan ivan386@users.noreply.github.com