Add 'ipfs dht findprovs --num-providers' to allow choosing number of providers to find #3966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Miguel Torres <migueltorreslopez@gmail.com> Apply fmt License: MIT Signed-off-by: Miguel Torres <migueltorreslopez@gmail.com> Add format License: MIT Signed-off-by: Miguel Torres <migueltorreslopez@gmail.com>
whyrusleeping
requested changes
Jun 10, 2017
core/commands/dht.go
Outdated
| @@ -159,7 +160,15 @@ var findProvidersDhtCmd = &cmds.Command{ | |||
| return | |||
| } | |||
|
|
|||
| numProviders := 20 | |||
| numProviders, _, err := res.Request().Option("n").Int() | |||
There was a problem hiding this comment.
nitpick: would prefer using the long option name for the lookup here
License: MIT Signed-off-by: Miguel Torres <migueltorreslopez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3839
I was looking for ways to add tests to findProviders command when new option --num-providers is given. But could not find a good example on existing commands to test options.
One possibility is to use a mocking library to mock the Node, but I didn't want to introduce new library dependencies for such a trivial change.
Please advice if new tests are needed.
License: MIT
Signed-off-by: Miguel Torres migueltorreslopez@gmail.com