Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make: fix make install not installing dependencies #3848

Merged
merged 1 commit into from
Mar 31, 2017
Merged

make: fix make install not installing dependencies #3848

merged 1 commit into from
Mar 31, 2017

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Mar 31, 2017

License: MIT
Signed-off-by: Jakub Sztandera kubuxu@protonmail.ch

@Kubuxu
make: fix make install not installing dependencies
52a293a 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu Kubuxu added the status/in-progress In progress label Mar 31, 2017
@Kubuxu
Copy link
Member Author

Kubuxu commented Mar 31, 2017

Travis uses it but we ignored the problem as Travis fails frequently.

@Kubuxu Kubuxu added this to the Ipfs 0.4.9 milestone Mar 31, 2017
whyrusleeping
whyrusleeping approved these changes Mar 31, 2017
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have to wonder what else is lurking around in $(th) $(ESE)-make: $(file) CH += ANGE$

@whyrusleeping whyrusleeping merged commit 1c50ec0 into master Mar 31, 2017
@whyrusleeping whyrusleeping deleted the fix/make/install-no-deps branch March 31, 2017 15:53
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Mar 31, 2017
@Kubuxu
Copy link
Member Author

Kubuxu commented Mar 31, 2017

This was new change made in a bit of a rush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Ipfs 0.4.9
Development

Successfully merging this pull request may close these issues.
2 participants
@Kubuxu @whyrusleeping