merkledag: fix json marshalling of pbnode #3507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
Kubuxu
approved these changes
Dec 14, 2016
Kubuxu
requested changes
Dec 14, 2016
Kubuxu
reviewed
Dec 14, 2016
Kubuxu
approved these changes
Dec 14, 2016
|
I still can't figure the GH review stuff sometimes, sorry for the mess, it is now green, and I just wanted the red to go away. |
|
I would be very happy with some unit tests for it 😄 |
A panic would occur when a link was created with a nil cid, this should be allowable, just catch the potential problem and skip marshaling the cid. License: MIT Signed-off-by: Jeromy <why@ipfs.io>
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously
ipfs dag getof a protobuf hash resulted in very unexpected outputLicense: MIT
Signed-off-by: Jeromy why@ipfs.io