Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockstore: remove expensive debug statement in AllKeysChan #3384

Merged
merged 1 commit into from
Nov 15, 2016

Conversation

kevina
Copy link
Contributor

@kevina kevina commented Nov 14, 2016

Closes #3378

License: MIT
Signed-off-by: Kevin Atkinson k@kevina.org

License: MIT
Signed-off-by: Kevin Atkinson <k@kevina.org>
@kevina kevina added topic/perf Performance status/in-progress In progress labels Nov 14, 2016
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@whyrusleeping
Copy link
Member

just waiting on tests now...

@kevina
Copy link
Contributor Author

kevina commented Nov 15, 2016

@whyrusleeping looks like the tests passes (except js-ipfs-api which I don't see how this change could break).

@ghost
Copy link

ghost commented Nov 15, 2016

@kevina it looks unrelated, I filed ipfs-inactive/js-ipfs-http-client#424 for it

@whyrusleeping
Copy link
Member

LGTM, 🚢

@whyrusleeping whyrusleeping merged commit bc21966 into master Nov 15, 2016
@whyrusleeping whyrusleeping deleted the kevina/blockstore-kill-debug-stmt branch November 15, 2016 01:38
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Nov 15, 2016
@ghost ghost mentioned this pull request Dec 23, 2016
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/perf Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants